Vw addons #137
Merged
Vw addons #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kupermind
commented
May 17, 2024
kupermind
commented
- Adding view functions for removed nominees;
- Correcting variable names, natspecs, comments.
kupermind
commented
May 17, 2024
Comment on lines
+162
to
+163
| // Set of removed Nominee structs | ||
| Nominee[] public setRemovedNominees; |
There was a problem hiding this comment.
Adding a set to push removed nominees.
kupermind
commented
May 17, 2024
| /// @dev Get the total number of removed nominees. | ||
| /// @notice The zero-th default nominee Id with id == 0 does not count. | ||
| /// @return Total number of removed nominees. | ||
| function getNumRemovedNominees() external view returns (uint256) { |
There was a problem hiding this comment.
Number of removed nominees.
kupermind
commented
May 17, 2024
| /// @dev Gets a full set of removed nominees. | ||
| /// @notice The returned set includes the zero-th empty nominee instance. | ||
| /// @return Set of all the removed nominees in the contract. | ||
| function getAllRemovedNominees() external view returns (Nominee[] memory) { |
There was a problem hiding this comment.
Simple getter for the set of removed nominees.
There was a problem hiding this comment.
awesome, thank you
Tanya-atatakai
approved these changes
May 20, 2024
| /// @dev Gets a full set of removed nominees. | ||
| /// @notice The returned set includes the zero-th empty nominee instance. | ||
| /// @return Set of all the removed nominees in the contract. | ||
| function getAllRemovedNominees() external view returns (Nominee[] memory) { |
There was a problem hiding this comment.
awesome, thank you
mariapiamo
previously approved these changes
May 20, 2024
doc: re-audit
mariapiamo
approved these changes
May 21, 2024
77ph
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.